Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump FRR to 9.1.0 #163

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Bump FRR to 9.1.0 #163

merged 1 commit into from
Jun 28, 2024

Conversation

fedepaol
Copy link
Member

@fedepaol fedepaol commented Jun 27, 2024

Is this a BUG FIX or a FEATURE ?:

Uncomment only one, leave it on its own line:

/kind bug
/kind cleanup
/kind feature
/kind design
/kind flake
/kind failing
/kind documentation
/kind regression

What this PR does / why we need it:
Bumping FRR to 9.1.0

Special notes for your reviewer:

Release note:

Bump FRR to version 9.1.0

@fedepaol fedepaol force-pushed the bumpfrr10 branch 3 times, most recently from a8df13d to b336198 Compare June 27, 2024 15:59
@fedepaol fedepaol changed the title Bump FRR to 10.0.1 Bump FRR to 9.1.0 Jun 27, 2024
@karampok
Copy link
Contributor

[I] kka@f-t14s ~/w/g/m/frr-k8s (bumpfrr10 ✔)> rg "9\.0\.2"
RELEASE_NOTES.md
17:- FRR: bump to 9.0.2, allow to peer with localhost ([PR 118](https://github.com/metallb/frr-k8s/pull/118))

internal/frr/docker_test.go
27:     frrImageTag = "9.0.2"

hack/demo/demo.sh
16:docker run -d --privileged --network kind --rm --ulimit core=-1 --name frr --volume "$FRR_CONFIG":/etc/frr quay.io/frrouting/frr:9.0.2

any of this references to older frr image should be updated? I suppose the RELEASE note entry is added when releasing.

@karampok
Copy link
Contributor

Why you do not bump in the latest frr?

skopeo list-tags docker://quay.io/frrouting/frr
{
    "Repository": "quay.io/frrouting/frr",
    "Tags": [
        "10.0.0",
        "10.0.1",

if there is a reason could we add it in the description of the commit?

@fedepaol
Copy link
Member Author

[I] kka@f-t14s ~/w/g/m/frr-k8s (bumpfrr10 ✔)> rg "9\.0\.2"
RELEASE_NOTES.md
17:- FRR: bump to 9.0.2, allow to peer with localhost ([PR 118](https://github.com/metallb/frr-k8s/pull/118))

internal/frr/docker_test.go
27:     frrImageTag = "9.0.2"

hack/demo/demo.sh
16:docker run -d --privileged --network kind --rm --ulimit core=-1 --name frr --volume "$FRR_CONFIG":/etc/frr quay.io/frrouting/frr:9.0.2

any of this references to older frr image should be updated? I suppose the RELEASE note entry is added when releasing.

Good catch!

@fedepaol
Copy link
Member Author

Why you do not bump in the latest frr?

skopeo list-tags docker://quay.io/frrouting/frr
{
    "Repository": "quay.io/frrouting/frr",
    "Tags": [
        "10.0.0",
        "10.0.1",

if there is a reason could we add it in the description of the commit?

I tried the latest, CI started failing for no clear reasons, so I assume latest is not super stable and went to the previous generation which still fixes my problem with importing vrfs.
I'll leave a comment.

@karampok
Copy link
Contributor

Ack, then maybe you could state that not bumping to latest due to ci is failing), and what is the reason you bump (fixes my problem, which problem?)

Also we could have an issue "bump to FRR 10" to follow it

Bumping FRR to the 9.1.0 version.

Among others, this fixes importing VRFs when a network is defined in a
router belonging to a vrf and another router imports that VRF.

Signed-off-by: Federico Paolinelli <[email protected]>
@fedepaol
Copy link
Member Author

Ack, then maybe you could state that not bumping to latest due to ci is failing), and what is the reason you bump (fixes my problem, which problem?)

I won't state why I am not bumping on a later version as it might be obsoleted / fixed when we look at it in the future.
Hopefully, 10.x will be stable and pass in our CI in the future.

@fedepaol
Copy link
Member Author

Also we could have an issue "bump to FRR 10" to follow it

Filed #165 , but not sure I want us to work / bump on that any time soon.

@fedepaol fedepaol merged commit db0cb1c into metallb:main Jun 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants